[Refactor] to simplify and extract the shared logic between chat completion and responses#27961
Merged
chaunceyjiang merged 8 commits intovllm-project:mainfrom Nov 5, 2025
Merged
Conversation
chaunceyjiang
added
the
ready
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
chaunceyjiang
force-pushed
the
tool_call_refactor
branch
2 times, most recently
from
c46a8c8 to
66d796b
Compare
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…letion and responses Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
force-pushed
the
tool_call_refactor
branch
from
66d796b to
5e8cce0
Compare
Collaborator
Author
|
/cc @aarnphm PTAL. |
aarnphm
approved these changes
Nov 5, 2025
ZhengHongming888
pushed a commit
to ZhengHongming888/vllm
that referenced
this pull request
Nov 8, 2025
…letion and responses (vllm-project#27961) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…letion and responses (vllm-project#27961) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
[Refactor] to simplify and extract the shared logic between chat completion and responses
fix #26874 (comment)
Test Plan
see e2e
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.